Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): mostr.pub, Mitraのユーザーをフォローできない問題を修正 #11791

Merged
merged 6 commits into from
Sep 22, 2023
Merged

fix(backend): mostr.pub, Mitraのユーザーをフォローできない問題を修正 #11791

merged 6 commits into from
Sep 22, 2023

Conversation

typeling1578
Copy link
Contributor

What

Fixes #11122

Why

Additional info (optional)

v12の時点では${this.config.url}/follows/${follower.id}/${followee.id}だったようです。
また、Mitraを使用しているサーバーのユーザーも #11122 と同様の問題が発生します。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Patch coverage: 28.00% and no project coverage change.

Comparison is base (c836157) 78.90% compared to head (468ed0e) 78.90%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #11791   +/-   ##
========================================
  Coverage    78.90%   78.90%           
========================================
  Files          930      930           
  Lines        98292    98341   +49     
  Branches      7817     7822    +5     
========================================
+ Hits         77555    77596   +41     
- Misses       20737    20745    +8
Files Changed Coverage Δ
.../backend/src/core/activitypub/ApResolverService.ts 56.19% <28.00%> (-1.71%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Sep 6, 2023

${this.config.url}/follows/${followRequest.id}じゃないと問題が発生するから変えたはず

@typeling1578
Copy link
Contributor Author

ApResolverServiceを${this.config.url}/follows/${followRequest.id}の形式を処理できるように変更しました

@syuilo
Copy link
Member

syuilo commented Sep 22, 2023

おろ、なんかテストが失敗してますね

@syuilo syuilo merged commit 3bbc2e5 into misskey-dev:develop Sep 22, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 22, 2023

🙏🏻

@typeling1578 typeling1578 deleted the fix-invaild-follow-uri branch September 22, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mostr.pubのユーザーをフォローできない
2 participants
@typeling1578 @syuilo